Add std.stdio.File.setRawMode().

[JohanEngelen]

Especially for files that cannot be opened by the user in binary mode (like stdin and stdout), having only rawWrite and rawRead available is very limiting. To enable binary/raw file operation for stdin and stdout, the code to set those streams to binary mode is non-trivial. setRawMode() resolves this issue.

[JohanEngelen]

(made fixes, squashed into one commit again)

[Hackerpilot]

Looks reasonable.

[quickfur]

Hmm. I don't like exposing OS-level implementation details like this. I prefer lockingBinaryWriter as implemented in PR #2011. Under the hood it basically does the same thing, but the API is cleaner, works nicely as an output range, and fits in better with the already existing lockingTextWriter.

[CyberShadow]

I don't disagree with the idea, but this needs to be a toggle. "Binary mode" is also the correct term here.

An alternative would be to provide a way to reopen stdin/out/err with arbitrary modes.

I don't like exposing OS-level implementation details like this.

For the record this is the C library API and Windows-only, so nothing OS-level.

BTW, this needs a correspoding Bugzilla issue.

[JohanEngelen]

Related bug reports:
https://issues.dlang.org/show_bug.cgi?id=7033
https://issues.dlang.org/show_bug.cgi?id=4243
https://issues.dlang.org/show_bug.cgi?id=9455
https://issues.dlang.org/show_bug.cgi?id=10545

[CyberShadow]

https://issues.dlang.org/show_bug.cgi?id=9455
https://issues.dlang.org/show_bug.cgi?id=10545

Perhaps these can be combined into a property, binaryMode. This would allow querying and toggling either way.

[JohanEngelen]

About lockingBinaryWriter: yes, would be great! But, it is not exactly the same: it locks.

About OS-level stuff: I think the basic problem is not setmode, it is the Digital Mars IO stuff that is troublesome. There should be a function (with sane name) for atomicOp!"&="(__fhnd_info[fd], ~FHND_TEXT);.

I first thought about setBinaryMode, setTextMode, but then I thought that that would somehow expose to much detail (and it doesn't actually set binary mode on non-Windows). Then I figured that the functionality is basically a permanent rawWrite, so "raw" stuck.
Anyway, I am happy to change the PR naming / toggling to your liking. However, I don't want to keep resubmitting this thing; so please discuss and come to a conclusion for me :-)

[JohanEngelen]

variable not used, remove.

[JakobOvrum]

Note that if you include Fix ticket 7033 etc. in the commit message, a bot will automatically link them and mark them as resolved when/if the commits are merged.

[andralex]

The terminology is binary vs. text. Then we probably need a means to get the current mode, so there's no escaping the API:

enum FileMode { text, binary }
void getMode(FileMode);
void setMode(FileMode);

[andralex]

ping?

[JohanEngelen]

sorry, guess I should have closed this.