Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Mar 4, 2016

Hey I came by std.stdio and saw that you don't show the unittest examples for rawRead, rawText, ... even though they are quite nice.
Moreover I removed static from the import as those unittests will now be displayed to the users.

I also saw that the unittest for byRecord is in comments for no (commented) reason. Anyone remembers this?

Git blame goes to @andralex
I know it was 7 years ago, but do you by chance have any memories?

}

///
unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byRecord itself still isn't documented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm either this was done on purpose, but then the entire method shouldn't be in here?

Otherwise let's add some doc.
Still waiting for the answer of experienced Phobos member about the history of byRecord.
It does seem useful...

@wilzbach wilzbach force-pushed the stdio_doc branch 2 times, most recently from 3e158f1 to 9b1c7c1 Compare March 12, 2016 12:54
@wilzbach
Copy link
Contributor Author

rebased as byRecord is now a separate PR (#4079).

@DmitryOlshansky
Copy link
Member

LGTM

@wilzbach
Copy link
Contributor Author

LGTM

anyone objecting?
(It just makes some unittests ddoced and changes the variable name from deleteme to testFile)

@JakobOvrum
Copy link
Contributor

Auto-merge toggled on

JakobOvrum added a commit that referenced this pull request Mar 17, 2016
std.stdio: add unittest examples to doc output
@JakobOvrum JakobOvrum merged commit f12b78e into dlang:master Mar 17, 2016
@wilzbach wilzbach deleted the stdio_doc branch March 23, 2016 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants