Skip to content

Conversation

@wilzbach
Copy link
Contributor

It turns out that I forgot to sed for for and there was an double occurrence of foreach in std/encoding.d.
I am terribly sorry for the spam.

@JackStouffer
Copy link
Contributor

LGTM

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

@DmitryOlshansky DmitryOlshansky merged commit c1027f1 into dlang:master Apr 27, 2016
@trikko
Copy link
Contributor

trikko commented Apr 28, 2016

It adds spaces after "for" key, but what about:

for ( int i = 0; i < indent; i++ )

vs

for (int i = 0; i < indent; i++)

?

@DmitryOlshansky
Copy link
Member

Never seen the first style in Phobos, so the latter is prefered I guess.

@trikko
Copy link
Contributor

trikko commented Apr 28, 2016

I see it. For example on changed files for this pull request:

std/concurrency.d 1989, 2133, ...

I think it can fix this too.

@wilzbach wilzbach deleted the sed_spaces_part_2 branch April 28, 2016 08:36
@wilzbach
Copy link
Contributor Author

I think it can fix this too.

@trikko do you mean "I"?
Don't forget to add a regex to check for this in the future to the .travis.yml then ;-)

@trikko
Copy link
Contributor

trikko commented Apr 28, 2016

Yes, I wrote "I think" 👍 eheh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants