std.algorithm.searching.extremum - fix float comp in unittest #4255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure this is necessary. Seems like a false positive. Comparisons of two float literals are expected to be exact (except for NaN etc.), though might fail if the number gets in/out of a FPU register (which may or may not indicate a compiler bug). |
wilzbach
force-pushed
the
fix_travis
branch
2 times, most recently
from
52b4627 to
45fe2e0
Compare
Contributor
Author
It seems more like a bug, that I couldn't reproduce in other functions. Just rearranging the method solves the error. I hope this doesn't occur in the future... |
Member
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andralex @CyberShadow @Hackerpilot turns out that Dscanner also scans for this errors that slipped that slipped through. Travis should pass now ;-)
Maybe we should have autotester check Travis from now on...
Edit: for reference introduced by #4221