std.range: document public methods#4313
Merged
andralex merged 1 commit intodlang:masterfrom Jun 18, 2016
Merged
Conversation
std/range/package.d
Outdated
| public: | ||
| @property inout(T) front() inout { return _value; } | ||
| @property inout(T) back() inout { return _value; } | ||
| /// |
Contributor
There was a problem hiding this comment.
Should have comment like "Range primitives"
wilzbach
force-pushed
the
public_document_range
branch
from
a8db4aa to
716c3c3
Compare
Contributor
Author
I think most of the code had the "long style", but I don't remember anymore. |
wilzbach
force-pushed
the
public_document_range
branch
2 times, most recently
from
59a67d0 to
cc10651
Compare
std/range/package.d
Outdated
| } | ||
|
|
||
| // Nonstandard | ||
| /// Nonstandard |
Contributor
There was a problem hiding this comment.
You're going to want something a little more descriptive here. What about this is non-standard and why does that matter?
Contributor
|
Everything else looks good |
wilzbach
force-pushed
the
public_document_range
branch
from
cc10651 to
493c989
Compare
Contributor
|
LGTM |
| } | ||
|
|
||
| /** | ||
| This template simply aliases itself to R and is useful for consistency in |
Member
|
will pull, feel free to address the nit in a later pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #4312