hotfix (tester) - Easter Island & Haiti Windows time zone#4317
Merged
Hackerpilot merged 1 commit intomasterfrom May 13, 2016
unknown repository
Merged
hotfix (tester) - Easter Island & Haiti Windows time zone#4317Hackerpilot merged 1 commit intomasterfrom unknown repository
Hackerpilot merged 1 commit intomasterfrom
unknown repository
Conversation
ghost
changed the title
Author
|
win_32_64 passed, we need auto-merge toggled on ASAP thx. |
Author
|
linux_64_64 failure is unrelated, the demand is still valid. |
Contributor
|
Auto-merge toggled on |
ghost
deleted the
Author
|
@MartinNowak don't forget to cherry pick in stable ;) |
9rnsr
pushed a commit
to 9rnsr/phobos
that referenced
this pull request
May 13, 2016
hotfix (tester) - Easter Island & Haiti Windows time zone
Contributor
|
I opened #4321 to cherry-pick the change into stable branch. |
9rnsr
added a commit
that referenced
this pull request
May 13, 2016
Cherry-pick commtis in #4317 from master to stable branch
Author
|
Nice. It' important for me to fix the hot stuffs before I leave. My daughter gets a bit angry otherwise... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows tester systematically fails because a new windows time zone entry was added for the Easter Island.
https://blogs.technet.microsoft.com/dst2007/2016/03/23/time-zone-update-for-chile-and-haiti/
This PR fixes the two functions involved. (tzDatabaseNameToWindowsTZName and windowsTZNameToTZDatabaseName). They're gonna be deprecated in next rlz but they still need to be maintained.
reference for the names: