std.uni: use selective imports and document module-scope imported symbols#4365
Merged
DmitryOlshansky merged 1 commit intodlang:masterfrom May 27, 2016
joakim-noah:uni_imports
Merged
std.uni: use selective imports and document module-scope imported symbols#4365DmitryOlshansky merged 1 commit intodlang:masterfrom joakim-noah:uni_imports
DmitryOlshansky merged 1 commit intodlang:masterfrom
joakim-noah:uni_imports
Conversation
…e scope, checked with ddmd
Contributor
|
LGTM - you should write a script that can do this automatically for entire Phobos :) |
| bool empty() @property { return s.empty; } | ||
| dchar front() @property { return s.front; } | ||
| void popFront() { s.popFront(); } | ||
| bool empty() @property { import std.range.primitives : empty; return s.empty; } |
Contributor
Author
There was a problem hiding this comment.
I tried sticking the import at the top of the struct but started getting template instantiation errors. Would you like me to reindent these?
Contributor
Author
That's the plan, I'd like to tie ddmd to dfix and make a tool that will automate this eventually. |
Member
|
Auto-merge toggled on |
This was referenced May 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked by dumping data from ldc frontend, as done for other modules, #4361.