Have travis enforce Allman brace style#4368
Closed
JackStouffer wants to merge 1 commit intodlang:masterfrom
Closed
Have travis enforce Allman brace style#4368JackStouffer wants to merge 1 commit intodlang:masterfrom
JackStouffer wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
@JackStouffer I made a PR to Dscanner to support this and avoid the case of false positives ;-) Ping @Hackerpilot |
Contributor
|
@JackStouffer there are more than 2K matches - subtracting the false positives (when the closing parenthesis is on the same line), that's still quite a lot. |
Contributor
Author
|
@wilzbach I would need to make the regex for it, which I said I don't know how to do. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could use a little regex help with this one.
The given regex gives false positives for things like
which are legal. I have the following regex to detect this case
The problem is I don't know how to grep for all matches of the first regex but that don't also match the second pattern.