Fix whitespace for selective imports#4380
Merged
DmitryOlshansky merged 2 commits intodlang:masterfrom May 31, 2016
Merged
Conversation
Unified with: sed -E "s/import\s*([^ ]+)\s*:\s*(.*(,|;))/import \1 : \2/" -i **/*.d
Contributor
|
LGTM |
Contributor
|
LGTM too. |
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a space before and after the colon for selective imports seems to be an informal rule and has been critized in many PR's.
I personally prefer import std.range: zip instead of std.range : zip, but the point is to make it a rule and standardize it, so we can automatically check it & no further time is wasted about such nitpicks.
It seems to me that this is can be easily unified and from now on checked with Travis
Command used:
Disclaimer: Yes the
grepcheck in Travis doesn't check all cases, but soon dscanner will catch up and this small loophole will be fixed.There is also an accomponying PR to dlang.org to update the DStyle.
Ping @joakim-noah @schuetzm