ignore case when looking for "charset"

[aG0aep6G]

RF2616 says: "The type, subtype, and parameter attribute names are case-insensitive."

https://tools.ietf.org/html/rfc2616#section-3.7

See also: http://forum.dlang.org/post/scoeormeciaoiqxsefkz@forum.dlang.org.

[wilzbach]

@aG0aep6G I just saw your style fixes ;-)

fix selective import style

FWIW at #4719 there's a make target (style).

[codecov-io]

Current coverage is 88.74% (diff: 100%)

Merging #4723 into master will decrease coverage by <.01%

@@             master      #4723   diff @@
==========================================
  Files           121        121          
  Lines         74037      74037          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          65705      65704     -1   
- Misses         8332       8333     +1   
  Partials          0          0          

Powered by Codecov. Last update 4a634ed...f87d112

[DmitryOlshansky]

Love the red but ... was it basically useless work duplicated elsewhere?

[aG0aep6G]

Love the red but ... was it basically useless work duplicated elsewhere?

The charset detection is already done in the other location that's touched by this PR: HTTP.onReceiveHeader. The function here calls that.

[DmitryOlshansky]

LGTM

[andralex]

nicely done

[andralex]

Auto-merge toggled on

[wilzbach]

@aG0aep6G ideally we can link every bug fix with a bugzilla issue, s.t. the end users sees what amazing work you / we did :)

[aG0aep6G]

@aG0aep6G ideally we can link every bug fix with a bugzilla issue, s.t. the end users sees what amazing work you / we did :)

You mean so that the users see what embarrassing bugs we used to have ;)

Can I retroactively link this to a bugzilla issue? Does the changelog script pick that up? I don't think a simple bug fix like this needs an entry in the prose section.

[wilzbach]

You mean so that the users see what embarrassing bugs we used to have ;)

Hehe no that they see what progress we make ;-)

Can I retroactively link this to a bugzilla issue? Does the changelog script pick that up? I don't think a simple bug fix like this needs an entry in the prose section.

AFAIK it's possible. I just created an issue & will check that the changelog script picks it up.

[aG0aep6G]

AFAIK it's possible. I just created an issue & will check that the changelog script picks it up.

Ok, thanks. I'll try to be more diligent in also filing issues when doing fixes.