Revert "[DEMO for DIP1005] Converted imports to selective imports in std.array"

[andralex]

Reverts #4963

[andralex]

cc @CyberShadow

[CyberShadow]

OK. Wasn't trying to stir anything up, just a bit confused :)

[MartinNowak]

Test failures due to code.dlang.org not being reachable intermediately.

[joakim-noah]

Don't add the space back.

[wilzbach]

It's an automatic revert & the spaces before the if constraint are the common Phobos style

[andralex]

@wilzbach we've gone back and forth with the style. I think if should be flush with the previous line (no extra indent). Could you please work your magic on the autotester to make it so? :)

[wilzbach]

we've gone back and forth with the style. I think if should be flush with the previous line (no extra indent).

dlang/dlang.org#1534

Could you please work your magic on the autotester to make it so?

I will give it a try :)

[wilzbach]

Yeah it was nicer before :/

[wilzbach]

So I rebased this to master to retrigger the CIs.

1. Imho the status before with more selective import was better and if we do such changes I would prefer if we do them automated ;-)
2. For this sole time it's safe to ignore CircleCi as it tries to checkout this branch at DMD/Druntime and fails to do so. We should probably add some fallback code to master if the base_branch does exist at the other repos.

[wilzbach]

For this sole time it's safe to ignore CircleCi as it tries to checkout this branch at DMD/Druntime and fails to do so.

-> #4996

However

It turns out that the changing the selective import import std.meta : AliasSeq to a module-wide import std.meta; exposed leaked import symbols as e.g std.range as it publicly imports std.array.

As a consequence it was possible to use AliasSeq by importing std.range and someone did in the meantime - thus our CI errored correctly:

out/std_range_package.d(884): Error: template instance AliasSeq!(byte, ubyte, short, ushort, int, uint, long, ulong) template 'AliasSeq' is not defined
out/std_range_package.d(980): Error: template instance AliasSeq!(byte, ubyte, short, ushort, int, uint, long, ulong) template 'AliasSeq' is not defined

See #4981 for a fix.