Addendum PR4988 - dead-lock in std.allocator.free_list unittest#4993
Merged
andralex merged 1 commit intodlang:masterfrom Dec 24, 2016
Merged
Addendum PR4988 - dead-lock in std.allocator.free_list unittest#4993andralex merged 1 commit intodlang:masterfrom
andralex merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
b715717 to
07bd7d7
Compare
This fixes the actual unittest.
07bd7d7 to
f7e14e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=16352
#4988 Fixed the cause, this allows the test to fail properly.
What was typically happening was
Would fail the assertion (because of data race.)
I don't know why
scope(exit) tid.send(true);didn't allow the main thread to exit.Anyway, instead I used
ThreadGroup.joinAllto rethrow exceptions in the unit test thread.