Skip to content

Cleaned up auto decoding special case in std.conv.parse for integers#5014

Merged
JackStouffer merged 1 commit intodlang:masterfrom
JackStouffer:parse-decoding2
Jan 4, 2017
Merged

Cleaned up auto decoding special case in std.conv.parse for integers#5014
JackStouffer merged 1 commit intodlang:masterfrom
JackStouffer:parse-decoding2

Conversation

@JackStouffer
Copy link
Contributor

Based on Andrei's advice in #4674, I cleaned up the code here.

Now even faster.

Built with ldc2 -O5 -release, code here.

# new
Total time: 10 ms, 730 μs, and 5 hnsecs

#current
Total time: 36 ms, 573 μs, and 4 hnsecs

#old
Total time: 181 ms, 850 μs, and 5 hnsecs

@JackStouffer JackStouffer added the Review:Trivial typos, formatting, comments label Jan 4, 2017
@JackStouffer JackStouffer requested review from 9il and andralex January 4, 2017 18:57
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@JackStouffer
Copy link
Contributor Author

Auto-merge toggled on

@JackStouffer JackStouffer merged commit ea3fcd0 into dlang:master Jan 4, 2017
@JackStouffer JackStouffer deleted the parse-decoding2 branch January 4, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants