[Style] Enforce a .. b opSlice style #5179
Merged
andralex merged 3 commits intodlang:masterfrom Feb 22, 2017
Merged
Conversation
Commands: sed -E "s/([[:alnum:]])[.][.]([[:alnum:]])/\1 .. \2/g" -i **/*.d sed -E "s/([[:alnum:]])[.][.] ([[:alnum:]])/\1 .. \2/g" -i **/*.d sed -E "s/([[:alnum:]]) [.][.]([[:alnum:]])/\1 .. \2/g" -i **/*.d
1162173 to
6c9b626
Compare
Contributor
Author
I am worried about that as well (this is only intended to be an intermediate solution).
Of course, but the PR is pending since quite a while: dlang-community/D-Scanner#348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another check & automatic conversion.
@andralex I mainly did this because you keep nagging about this on PR reviews and there's really no point in wasting time during a review with such easily to check nits.
(for the record I prefer the
a..b)There were a few false positives with this very naive approach, hence I excluded the
std.stringandstd.unifor the start.Moreover, I hope you are aware of the following: