Conversation
|
| @@ -0,0 +1,28 @@ | |||
| New module `std.experimental.checkedint` defines `Checked`, a lightweight and | |||
There was a problem hiding this comment.
The format is equal to git messages.
- first line = title
- empty line
- long description
For more details see the other changelog files or the doc:
https://github.com/dlang/phobos/tree/master/changelog
9087415 to
4723df4
Compare
|
@burner looks good? |
As dlang/dlang.org#1549 hasn't been merged yet and it's a bit hard to manually preview, here's a screenshot: |
|
LGTM thx @wilzbach |
|
Auto-merge toggled on |
FWIW I didn't want to nag on this again as I thought it's easily seen in the picture. The changelog format is really, really simple (and equal to the behavior of |
And another FWIW the |
| @@ -0,0 +1,22 @@ | |||
| New: $(REF Checked, std, experimental, checkedint), a lightweight and highly | |||
There was a problem hiding this comment.
Don't put links in the subject/title line. The whole line is turned into a link to the body, and you can't have links within links. You can put the REF in the body.
The changelog tool should enforce that there's a blank line after the title line. Or, alternatively, allow multiple lines for the title, until the first blank line. |
|
Auto-merge toggled off |
Seems like we haven't been that consistent in the past either: https://github.com/dlang/phobos/blob/master/changelog/std-utf-decodeBack.dd (but the changelog tool ignored this violation softly)
Well in case we really want to go in this direction: dlang/tools#220 |
4723df4 to
2749175
Compare
@andralex: I fixed the changelog file manually (title in one line, no REF in the title) and force-pushed the PR, s.t. we can move forward with this. |
|
@wilzbach sorry and thanks for fixing that - I missed the REF part. Thanks for using your powers for good! |
-> Fixup & validator: #5199 |
|
@burner as I realized that some bits of the improved GH process might be new, I tried to summarize all changes that came to my mind: http://forum.dlang.org/post/qoamackqqnkqrxkochdu@forum.dlang.org |
@wilzbach