Temporarily disable project coverage #5197
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At CircleCi we merge the PR into the respective Phobos branch (e.g.
master,stable, ...) to simulate its effect on the regarding branch and to auto-update thecircleci.shandposix.mak.However, CodeCov doesn't these merges very well. In particular they completely ignore the new
parent_refand assume it to be the one of the PR. This means that all commits between theparent_refof a PR and the currentupstream/masterare also counted in thecodecov/projectinformation output.Hence, it usually looks pretty random and often shows red warnings.
-> a solution is to remove the
codecov/projectreport until CodeCov can handleparent_refproperly. The information on the coverage changes introduced by a PR was and will stay correct, except for CTFE and DMD bugs.To the people using the CodeCov extension to look at PRs: it's worth noting that due the incorrect handling of
parent_refCodeCov the coverage report might also be shifted by X lines (as there might have been a commit to the same file between theparent_refof the respective PR andupstream/master)Learn more:
https://github.com/codecov/support/issues/360