Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog/std-format-formattedRead-only-pointers.dd
Original file line number Diff line number Diff line change
@@ -1,2 +1,14 @@
`std.format.formattedRead` now only accepts pointers as input arguments.

For example, the "bad" version of the following code lead to very confusing
errors from Phobos.

-------
import std.format;
void main() {
int[3] row;
auto text = "10 20 30";
//formattedRead(text, "%(%d %)", row); // bad
formattedRead(text, "%(%d %)", &row); // OK
}
-------
2 changes: 2 additions & 0 deletions changelog/std-random-MersenneTwisterEngine.dd
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
`MersenneTwisterEngine` has been updated so that its template signature matches the C++11 standard.

`MersenneTwisterEngine` has been updated so that its template signature
matches the C++11 standard (adding two new template parameters, an extra
tempering parameter `d` and the initialization multiplier `f`).
Expand Down
2 changes: 1 addition & 1 deletion changelog/std-range-bitwise.dd
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Added `std.range.bitwise` to create a bitwise adapter over an integral type range, consuming the range elements bit by bit.

`std.range.bitwise` creates a bit by bit adapter over an integral type range.
`std.range.bitwise` creates a bit by bit adapter over an integral type range:
-------
import std.range : bitwise;
ubyte[] arr = [3, 9];
Expand Down
12 changes: 12 additions & 0 deletions changelog/std-stdio-readf-only-pointers.dd
Original file line number Diff line number Diff line change
@@ -1,2 +1,14 @@
`std.stdio.readf` now only accepts pointers as input arguments.

For example, the "bad" version of the following code lead to very confusing
errors from Phobos:

-------
import std.stdio;
void main() {
int[3] row;
auto text = "10 20 30";
//readf(text, "%(%d %)", row); // bad
readf(text, "%(%d %)", &row); // OK
}
-------
1 change: 1 addition & 0 deletions changelog/std-utf-decodeBack.dd
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Added `std.utf.decodeBack` which decodes the last UTF code point of given character range.

-------
import std.utf : decodeBack;

Expand Down
10 changes: 10 additions & 0 deletions posix.mak
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,16 @@ style: ../dscanner/dsc $(LIB)
@echo "Enforce space between binary operators"
grep -nrE "[[:alnum:]](==|!=|<=|<<|>>|>>>|^^)[[:alnum:]]|[[:alnum:]] (==|!=|<=|<<|>>|>>>|^^)[[:alnum:]]|[[:alnum:]](==|!=|<=|<<|>>|>>>|^^) [[:alnum:]]" $$(find . -name '*.d'); test $$? -eq 1

@echo "Validate changelog files (Do _not_ use REF in the title!)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Copy link
Contributor Author

@wilzbach wilzbach Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with all other checks. If you want to make the checks less noisy, I am happy to do so, but then we should do this for all checks and then in another PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then things should be fine for this PR at least. Thanks!

@for file in $$(find changelog -name '*.dd') ; do \
cat $$file | head -n1 | grep -nqE '\$$\((REF|LINK2|HTTP|MREF)' && \
{ echo "$$file: The title line can't contain links - it's already a link" && exit 1; } ;\
cat $$file | head -n2 | tail -n1 | grep -q '^$$' || \
{ echo "$$file: After the title line an empty, separating line is expected" && exit 1; } ;\
cat $$file | head -n3 | tail -n1 | grep -nqE '^.{1,}$$' || \
{ echo "$$file: The title is supposed to be followed by a long description" && exit 1; } ;\
done

@echo "Check that Ddoc runs without errors"
$(DMD) $(DFLAGS) -defaultlib= -debuglib= $(LIB) -w -D -main -c -o- $$(find etc std -type f -name '*.d' | grep -vE 'std/experimental/ndslice/iteration.d') 2>&1 | grep -v "Deprecation:"; test $$? -eq 1

Expand Down