Conversation
| @echo "Check for trailing whitespace" | ||
| grep -nr '[[:blank:]]$$' etc std ; test $$? -eq 1 | ||
| @grep -nr '[[:blank:]]$$' etc std && \ | ||
| { echo "Check for trailing whitespace" && exit 1; } ; exit 0 |
There was a problem hiding this comment.
Cool, one simpler pattern that would work is: pipe && { echo ... && return 1 } || return 0
The shell evaluates all && and || indiscriminately left to right. Eh, I guess not much of a simplification, up to you.
Also I'm using return instead of exit because I'm under the delusion one day we may use https://www.gnu.org/software/make/manual/html_node/One-Shell.html
wilzbach
force-pushed
the
style-make-silent
branch
from
acfa677 to
7efde72
Compare
|
ping @wilzbach Merge conflict; please rebase. This has been sitting here for far too long; let's get it merged! |
|
Hmm I never really cared about this target and as no one pushed for this, I am just going to close it. |
4 participants
This is a short follow-up to #5199 and this PR sets calls and
echos in thestyletarget to silent as Andrei requested. A message(s) will only be printed in case of an error.However, I am not so convinced that this is a good idea because (a) it might make debugging more difficult and (b) there will be no visual feedback for 10-15s.
Anyways here are the potential changes.
(I opened this PR because I am fine with both ways.)