Skip to content

std.conv: Fix off-by-one regression in integer radix parse #5204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackStouffer merged 1 commit into from
Feb 27, 2017
Merged

std.conv: Fix off-by-one regression in integer radix parse #5204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion std/conv.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2401,7 +2401,7 @@ body

bool overflow = false;
auto nextv = v.mulu(radix, overflow).addu(c - '0', overflow);
enforce!ConvOverflowException(!overflow && nextv < Target.max, "Overflow in integral conversion");
enforce!ConvOverflowException(!overflow && nextv <= Target.max, "Overflow in integral conversion");
v = cast(Target) nextv;
s.popFront();
} while (!s.empty);
Expand All @@ -2428,6 +2428,8 @@ body

// 6609
assert(parse!int(s = "-42", 10) == -42);

assert(parse!ubyte(s = "ff", 16) == 0xFF);
}

@safe pure unittest // bugzilla 7302
Expand Down