Add public API for regex charset parser #5337

DmitryOlshansky · 2017-04-17T03:05:35Z

It's a bunch of unwieldy code that I planed to reuse long ago.
Libraries such as ICU also do provide means to construct sets of codepoints from strings with regex syntax.

wilzbach · 2017-05-06T14:11:36Z

@DmitryOlshansky
FYI failing on the auto-tester

generated/d_do_test.o(.text._D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya+0x3d): In function `_D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya+0x79): In function `_D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv+0x38): In function `_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5emptyMFNaNbNdNiNfZb'
generated/d_do_test.o(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv+0x4a): In function `_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5frontMFNaNbNdNiNfZa'
generated/d_do_test.o(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv+0x5b): In function `_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result8popFrontMFNaNbNiNfZv'
generated/d_do_test.o(.text._D3std4conv17__T6toImplTAyaTkZ6toImplFNaNbNekkE3std5ascii10LetterCaseZAya+0x51): In function `_D3std4conv17__T6toImplTAyaTkZ6toImplFNaNbNekkE3std5ascii10LetterCaseZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa+0x10): In function `_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result6lengthMFNaNbNdNiNfZk'
generated/d_do_test.o(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa+0x4b): In function `_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5emptyMFNaNbNdNiNfZb'
generated/d_do_test.o(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa+0x57): In function `_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5frontMFNaNbNdNiNfZa'
generated/d_do_test.o(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa+0x8c): In function `_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result8popFrontMFNaNbNiNfZv'
generated/d_do_test.o(.text._D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya+0x3d): In function `_D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya+0xb5): In function `_D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std4conv30__T8textImplTAyaTAyaTkTAyaTykZ8textImplFNaNbNfAyakAyaykZAya+0x3d): In function `_D3std4conv30__T8textImplTAyaTAyaTkTAyaTykZ8textImplFNaNbNfAyakAyaykZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std4conv23__T8textImplTAyaTAyaTkZ8textImplFNaNbNfAyakZAya+0x3d): In function `_D3std4conv23__T8textImplTAyaTAyaTkZ8textImplFNaNbNfAyakZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o(.text._D3std4conv27__T8textImplTAyaTAyaTkTAyaZ8textImplFNaNbNfAyakAyaZAya+0x3a): In function `_D3std4conv27__T8textImplTAyaTAyaTkTAyaZ8textImplFNaNbNfAyakAyaZAya':
: undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
Error: linker exited with status 1

DmitryOlshansky · 2017-05-06T15:02:20Z

Let's hope it likes it now.

wilzbach · 2017-05-08T20:07:24Z

Let's hope it likes it now.

OS: linux
generated/d_do_test.o: In function `_D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya':
d_do_test.d:(.text._D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya[_D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya]+0x3d): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
d_do_test.d:(.text._D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya[_D3std4conv29__T8textImplTAyaTAyaTkTAyaTkZ8textImplFNaNbNfAyakAyakZAya]+0x79): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o: In function `_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv':
d_do_test.d:(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv[_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv]+0x38): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5emptyMFNaNbNdNiNfZb'
d_do_test.d:(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv[_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv]+0x4a): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5frontMFNaNbNdNiNfZa'
d_do_test.d:(.text._D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv[_D3std5array17__T8AppenderTAyaZ8Appender94__T3putTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ3putMFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZv]+0x5b): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result8popFrontMFNaNbNiNfZv'
generated/d_do_test.o: In function `_D3std4conv17__T6toImplTAyaTkZ6toImplFNaNbNekkE3std5ascii10LetterCaseZAya':
d_do_test.d:(.text._D3std4conv17__T6toImplTAyaTkZ6toImplFNaNbNekkE3std5ascii10LetterCaseZAya[_D3std4conv17__T6toImplTAyaTkZ6toImplFNaNbNekkE3std5ascii10LetterCaseZAya]+0x51): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o: In function `_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa':
d_do_test.d:(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa[_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa]+0x10): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result6lengthMFNaNbNdNiNfZk'
d_do_test.d:(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa[_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa]+0x4b): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5emptyMFNaNbNdNiNfZb'
d_do_test.d:(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa[_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa]+0x57): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result5frontMFNaNbNdNiNfZa'
d_do_test.d:(.text._D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa[_D3std5array96__T5arrayTS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZ5arrayFNaNbNfS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6ResultZAa]+0x8c): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result8popFrontMFNaNbNiNfZv'
generated/d_do_test.o: In function `_D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya':
d_do_test.d:(.text._D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya[_D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya]+0x3d): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
d_do_test.d:(.text._D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya[_D3std4conv36__T8textImplTAyaTAyaTkTAyaTykTAyaTkZ8textImplFNaNbNfAyakAyaykAyakZAya]+0xb5): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o: In function `_D3std4conv30__T8textImplTAyaTAyaTkTAyaTykZ8textImplFNaNbNfAyakAyaykZAya':
d_do_test.d:(.text._D3std4conv30__T8textImplTAyaTAyaTkTAyaTykZ8textImplFNaNbNfAyakAyaykZAya[_D3std4conv30__T8textImplTAyaTAyaTkTAyaTykZ8textImplFNaNbNfAyakAyaykZAya]+0x3d): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o: In function `_D3std4conv23__T8textImplTAyaTAyaTkZ8textImplFNaNbNfAyakZAya':
d_do_test.d:(.text._D3std4conv23__T8textImplTAyaTAyaTkZ8textImplFNaNbNfAyakZAya[_D3std4conv23__T8textImplTAyaTAyaTkZ8textImplFNaNbNfAyakZAya]+0x3d): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
generated/d_do_test.o: In function `_D3std4conv27__T8textImplTAyaTAyaTkTAyaZ8textImplFNaNbNfAyakAyaZAya':
d_do_test.d:(.text._D3std4conv27__T8textImplTAyaTAyaTkTAyaZ8textImplFNaNbNfAyakAyaZAya[_D3std4conv27__T8textImplTAyaTAyaTkTAyaZ8textImplFNaNbNfAyakAyaZAya]+0x3a): undefined reference to `_D3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZS3std4conv47__T7toCharsVhi10TaVE3std5ascii10LetterCasei1TkZ7toCharsFNaNbNiNfkZ6Result'
collect2: error: ld returned 1 exit status
Error: linker exited with status 1
Makefile:201: recipe for target 'generated/d_do_test' failed

MetaLang · 2017-08-06T04:55:04Z

This has been green for awhile now. How should we move forward with this?

mb64 · 2017-08-07T21:22:19Z

std/uni.d

+    return val;
+}
+
+@system unittest //BUG canFind is system


While it's being moved, I think it's worth noting that canFind is no longer system (see its @safe unittest), so this can be changed.

DmitryOlshansky · 2017-08-08T07:03:44Z

This has been green for awhile now. How should we move forward with this?

From my side, absoultely - pry won't build without this patch, which is hardly increasing its usability.
Let's just check what's the matter with circle-ci.

wilzbach · 2017-08-08T07:46:06Z

std/uni.d

 import std.traits; // isConvertibleToString, isIntegral, isSomeChar,
    // isSomeString, Unqual
-
+import std.exception; // enforce


Please use selective imports to avoid symbol leakage.

Last time I checked it was the other way around

Yes, but then we discovered that non-selective imports are leaking:

#5584 (comment)

tl;dr: if you add std.exception here, people can import all symbols from std.exception from std.uni

@wilzbach according to the linked comment even selective imports leak so it wouldn't help to change it.

Oh for **ck sake... I'll change this one but the other will stay as is for now, I don't want to mix concerns in a single pull request that supposed to be refactoring.

wilzbach · 2017-08-08T07:46:44Z

std/uni.d

+    ///
+    @safe unittest
+    {
+        import std.uni;


CI error is:

Local imports should specify the symbols being imported to avoid hiding local symbols.

wilzbach · 2017-08-08T07:47:10Z

std/uni.d

+    static package CodepointSet parsePropertySpec(Range)(ref Range p,
+        bool negated, bool casefold)
+    {
+        import std.ascii;


CI error

Local imports should specify the symbols being imported to avoid hiding local symbols.

This only does the move without adapting the interface to the commonly accepted ranges.

dlang-bot · 2017-08-24T08:25:59Z

Thanks for your pull request, @DmitryOlshansky!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

MetaLang · 2017-08-24T13:47:50Z

The only other concern is the test coverage (29% seems pretty poor), but I don't know if that's worth delaying merging.

DmitryOlshansky · 2017-08-24T14:03:58Z

The only other concern is the test coverage (29% seems pretty poor), but I don't know if that's worth delaying merging.

I'm tired to hell of explaining that our FREAKING AMAZING CI will only do a FILE AT A TIME TEST to show coverage. Regex tests live in a separate file, no way a file at a time will catch proper coverage stats.

TL;DR: Our coverage report is horribly broken, not my problem though.

MetaLang · 2017-08-24T14:18:28Z

@DmitryOlshansky fair enough. I'll leave it to @wilzbach to merge.

wilzbach · 2017-08-24T14:36:02Z

I'm tired to hell of explaining that our FREAKING AMAZING CI will only do a FILE AT A TIME TEST to show coverage. Regex tests live in a separate file, no way a file at a time will catch proper coverage stats.

Yup.

TL;DR: Our coverage report is horribly broken, not my problem though

Yes :/

quickfur · 2017-11-02T20:36:53Z

This PR caused a -dip1000 regression: https://issues.dlang.org/show_bug.cgi?id=17961

tl;dr: Now it's impossible to compile any D code with -unittest -dip1000 if std.uni is used anywhere in the code.

quickfur · 2018-02-05T21:19:16Z

This PR also caused a regression in compilation times: https://issues.dlang.org/show_bug.cgi?id=18378

:-(

wilzbach · 2018-02-05T21:23:57Z

See #5981

quickfur · 2018-02-05T21:41:03Z

I'm talking about compilation speed, not the performance of the regex code itself. Both need to be fixed. :-P

DmitryOlshansky force-pushed the uni-regex-charset branch 2 times, most recently from ccbbc17 to 0dd4244 Compare April 23, 2017 18:00

DmitryOlshansky force-pushed the uni-regex-charset branch from 0dd4244 to 680c07c Compare May 6, 2017 15:00

wilzbach added the Review:Needs Work label May 25, 2017

MetaLang removed the Review:Needs Work label Aug 6, 2017

mb64 reviewed Aug 7, 2017

View reviewed changes

wilzbach reviewed Aug 8, 2017

View reviewed changes

DmitryOlshansky mentioned this pull request Aug 20, 2017

parser.d references non-existant method std.uni.unicode.parseSet DmitryOlshansky/pry-parser#6

Closed

DmitryOlshansky added 2 commits August 23, 2017 19:17

Move unicode set parser out of std.regex

905788a

This only does the move without adapting the interface to the commonly accepted ranges.

Rangify std.regex codepoint set parser

bc14c02

DmitryOlshansky force-pushed the uni-regex-charset branch from 680c07c to bc14c02 Compare August 24, 2017 08:25

std.uni : appease circle-CI checks

5d0c5db

MetaLang approved these changes Aug 24, 2017

View reviewed changes

wilzbach approved these changes Aug 24, 2017

View reviewed changes

wilzbach added the Merge:auto-merge label Aug 24, 2017

dlang-bot merged commit c648bca into dlang:master Aug 24, 2017

Uh oh!

Add public API for regex charset parser #5337

Add public API for regex charset parser #5337

Uh oh!

Conversation

DmitryOlshansky commented Apr 17, 2017

Uh oh!

wilzbach commented May 6, 2017

Uh oh!

DmitryOlshansky commented May 6, 2017

Uh oh!

wilzbach commented May 8, 2017

Uh oh!

MetaLang commented Aug 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmitryOlshansky commented Aug 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dlang-bot commented Aug 24, 2017

Bugzilla references

Uh oh!

MetaLang commented Aug 24, 2017

Uh oh!

DmitryOlshansky commented Aug 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MetaLang commented Aug 24, 2017

Uh oh!

wilzbach commented Aug 24, 2017

Uh oh!

quickfur commented Nov 2, 2017

Uh oh!

quickfur commented Feb 5, 2018

Uh oh!

wilzbach commented Feb 5, 2018

Uh oh!

quickfur commented Feb 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DmitryOlshansky commented Aug 24, 2017 •

edited

Loading