Remove redundant access specifier from Phobos

[wilzbach]

Follow-up to #5466 (comment) and preparation for the Dscanner plugin: dlang-community/D-Scanner#441

std.unit seems to quite generous with scope-wide access specifiers. Hence, it might also make sense to reduce the impact of the almost module-wide private: ...

CC @andralex @DmitryOlshansky

[CyberShadow]

Cool, but I thought the suggestion was

Oh, unindented private block. Thx. All blocks should be indented, @wilzbach how easy is this to enforce automatically?

[wilzbach]

Cool, but I thought the suggestion was

Oh, unindented private block. Thx. All blocks should be indented, @wilzbach how easy is this to enforce automatically?

I should read messages on my phone in more detail 😆
Anyways checking for indents, isn't a big deal, see e.g.

dlang-community/D-Scanner#394

(I also opened a new Dscanner issue).

[andralex]

I actually think there's merit in using private like this as opposed to the label form. In the label form the user has to browse in this case all the way up to line 98 to figure that the symbol is indeed private. And of course make sure there's no other intervening label. In the hierarchy of ease to assess, we have per-symbol (nicest), scope-introducing, and label.

Can you please change this PR a bit to only keep the label removals?

[wilzbach]

Btw in case someone is interested, I have thrown together a PR for Dscanner that allows to use white and blacklists of modules for specific checks, so hopefully once this PR is merged, we don't need to go "all-or-nothing" in the beginning, but can gradually increase the propagation of a check.

[andralex]

so what's the status here? on a cursory look lgtm

[wilzbach]

so what's the status here? on a cursory look lgtm

I think I discovered a small bug in the RedundantAccessAttribute checker, that's why this on hold. I will get back to it in the next few days. Sorry.

On the bright side (thanks to #5495), we now have selective check for modules and everyone can help out reducing the check-specific blacklisted modules.

https://github.com/dlang/phobos/blob/master/.dscanner.ini

[dlang-bot]

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#5477"

[RazvanN7]

@andralex I rebased this and should be good to go.

[andralex]

Fine, though I'm a fan of private attached to individual declaration (Java/C#/etc style) as opposed to long-acting private: which is brittle in the face of refactorings.