Skip to content

std.range.package: Fix DDoc syntax#5494

Merged
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170618-081855
Jun 18, 2017
Merged

std.range.package: Fix DDoc syntax#5494
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170618-081855

Conversation

@CyberShadow
Copy link
Member

@CyberShadow CyberShadow commented Jun 18, 2017

@CyberShadow CyberShadow mentioned this pull request Jun 18, 2017
Closed
PetarKirov
PetarKirov reviewed Jun 18, 2017
View reviewed changes
std/range/package.d Outdated
Copy link
Member

@PetarKirov PetarKirov Jun 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove `range.`, because the link already includes the module name on ddox - see http://dtest.dlang.io/artifact/website-d2e620d6b5bed7f6a50276392a7508505c3c2029-9649de2e244ad8868ecf2a1b2c6ed29c/web/library-prerelease/std/range/drop.html, and more importantly, because it seems to interact badly with ddoc - http://dtest.dlang.io/artifact/website-d2e620d6b5bed7f6a50276392a7508505c3c2029-9649de2e244ad8868ecf2a1b2c6ed29c/web/phobos-prerelease/std_range.html#drop.

Copy link
Member Author

@CyberShadow CyberShadow Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, it was the automatic recognition of arguments again. Fixed.

PetarKirov
PetarKirov reviewed Jun 18, 2017
View reviewed changes
std/range/package.d Outdated
Copy link
Member

@PetarKirov PetarKirov Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@PetarKirov
Copy link
Member

PetarKirov commented Jun 18, 2017

From the Jenkins log, while testing vibe.d:

2017-06-18T08:27:52.493:threads.d:destroyAsyncThreads:34 Failed to terminate worker threads: core.thread.ThreadException@src/core/thread.d(773): Unable to join thread

(https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fphobos/detail/PR-5494/1/pipeline#step-787-log-33)

I think this is a transient failure, but perhaps @MartinNowak may want to investigate.

@CyberShadow CyberShadow force-pushed the pull-20170618-081855 branch from 71f46e4 to 1c91f39 Compare June 18, 2017 10:32
PetarKirov
PetarKirov approved these changes Jun 18, 2017
View reviewed changes
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for prompt response, @CyberShadow!

@dlang-bot dlang-bot merged commit 548630d into dlang:master Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

Assignees

No one assigned

Labels

Merge:auto-merge Severity:Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CyberShadow @PetarKirov @dlang-bot

Comments