Skip to content

Comments

Re-add has_public_example to circleci.sh for legacy compatibility#5514

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:add-has-public-example
Jun 26, 2017
Merged

Re-add has_public_example to circleci.sh for legacy compatibility#5514
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:add-has-public-example

Conversation

@wilzbach
Copy link
Contributor

This should fix the CircleCi build failures on older PRs and avoids the unnecessary need to rebase.

Background: we merge the PR branch into the target branch, hence the newest circleci.sh is always applied, but unfortunately we the circle.yml isn't updated. While we could use just one target e.g. test, using multiple has the advantage of visually grouping them nicely and thus helping a reader to track down the root of the failure.

CC @CyberShadow @schveiguy @JackStouffer @ZombineDev

@CyberShadow
Copy link
Member

Sounds good to me.

What about stable?

@wilzbach
Copy link
Contributor Author

What about stable?

has_public_example is still part of stable: https://github.com/dlang/phobos/blob/stable/circleci.sh#L147
Btw I just looked at CircleCi and it seems that stable was/is building fine:

https://circleci.com/gh/dlang/phobos/tree/stable

@CyberShadow
Copy link
Member

Btw I just looked at CircleCi and it seems that stable was/is building fine:

Hmm, then why is #5511 failing?

@wilzbach
Copy link
Contributor Author

continuous-integration/jenkins/pr-merge — This commit cannot be built

Arrgh Jenkins failing again. Could we give fixes like dlang/ci#47 more priority (even if they don't solve the root cause)?

@wilzbach wilzbach force-pushed the add-has-public-example branch from b914942 to aa83f56 Compare June 26, 2017 19:53
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

(rebased as this is the only way I know to rekick Jenkins ...)

@wilzbach
Copy link
Contributor Author

Urrgh now dlang/dmd#6940 has propagated the version PR into master and CircleCI is now failing for master as well:

make: *** No rule to make target `../generated/linux/release/64/VERSION', needed by `../generated/linux/release/64/dmd'.  Stop.
make: *** Waiting for unfinished jobs....

@wilzbach
Copy link
Contributor Author

(yet another rebase to kick Jenkins)

@wilzbach
Copy link
Contributor Author

and yet another rebase for Jenkins ...

@dlang-bot dlang-bot merged commit 47aa7b9 into dlang:master Jun 26, 2017
@wilzbach wilzbach deleted the add-has-public-example branch December 11, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants