Remove old, redundant private import access specifier #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
A |
wilzbach
force-pushed
the
remove-private-imports
branch
2 times, most recently
from
869768f to
fdf795b
Compare
Very very old versions of D (well into 0.x) had imports public by default, like C header files. This modernizes the codebase and removes the redundant `private` access specifier. This has been done with: sed "s/private import/import/g" -i **/*.d
…ort into unittest
wilzbach
force-pushed
the
remove-private-imports
branch
from
fdf795b to
e8806ad
Compare
Contributor
Author
Yes, the only tricky bit is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very very old versions of D (well into 0.x) had imports public by default,
like C header files. This modernizes the codebase and removes the
redundant
privateaccess specifier.This has been done with:
See also: #5546 (comment)
CC @CyberShadow
I don't think it's worth adding a check here, because no one uses
private importnowadays.