Skip to content

Removed old debug printfs in std.string #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
Jul 7, 2017
Merged

Removed old debug printfs in std.string #5568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions std/string.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,6 @@ Source: $(PHOBOSSRC std/_string.d)
*/
module std.string;

//debug=string; // uncomment to turn on debugging trustedPrintf's

debug(string) private
void trustedPrintf(in char* str) @trusted nothrow @nogc
{
import core.stdc.stdio : printf;
printf("%s", str);
Copy link
Contributor

@wilzbach wilzbach Jul 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: we could do the same for writeln and use assumeNoGC + catch all Exceptions - it would be very, very handy for debugging. Hell, we could only version it with version(debug) ...

Copy link
Contributor Author

@JackStouffer JackStouffer Jul 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug statements already bypass the @nogc and pure attributes IIRC

Copy link
Member

@PetarKirov PetarKirov Jul 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they only bypass pure.

}

version (unittest)
{
private:
Expand Down Expand Up @@ -580,7 +571,6 @@ if (isConvertibleToString!Range)
import std.exception : assertCTFEable;
import std.traits : EnumMembers;
import std.utf : byChar, byWchar, byDchar;
debug(string) trustedPrintf("string.indexOf.unittest\n");

assertCTFEable!(
{
Expand Down Expand Up @@ -636,7 +626,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.traits : EnumMembers;
import std.utf : byCodeUnit, byChar, byWchar;
debug(string) trustedPrintf("string.indexOf(startIdx).unittest\n");

assert("hello".byCodeUnit.indexOf(cast(dchar)'l', 1) == 2);
assert("hello".byWchar.indexOf(cast(dchar)'l', 1) == 2);
Expand Down Expand Up @@ -835,7 +824,6 @@ if (!(isForwardRange!Range && isSomeChar!(ElementEncodingType!Range) &&
import std.conv : to;
import std.exception : assertCTFEable;
import std.traits : EnumMembers;
debug(string) trustedPrintf("string.indexOf.unittest\n");

assertCTFEable!(
{
Expand Down Expand Up @@ -906,7 +894,6 @@ unittest
{
import std.conv : to;
import std.traits : EnumMembers;
debug(string) trustedPrintf("string.indexOf(startIdx).unittest\n");

foreach (S; AliasSeq!(string, wstring, dstring))
{
Expand Down Expand Up @@ -1083,7 +1070,6 @@ if (isSomeChar!Char)
import std.conv : to;
import std.exception : assertCTFEable;
import std.traits : EnumMembers;
debug(string) trustedPrintf("string.lastIndexOf.unittest\n");

assertCTFEable!(
{
Expand Down Expand Up @@ -1124,8 +1110,6 @@ if (isSomeChar!Char)
import std.conv : to;
import std.traits : EnumMembers;

debug(string) trustedPrintf("string.lastIndexOf.unittest\n");

foreach (S; AliasSeq!(string, wstring, dstring))
{
assert(lastIndexOf(cast(S) null, 'a') == -1);
Expand Down Expand Up @@ -1310,8 +1294,6 @@ if (isSomeChar!Char1 && isSomeChar!Char2)
import std.exception : assertCTFEable;
import std.traits : EnumMembers;

debug(string) trustedPrintf("string.lastIndexOf.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1388,8 +1370,6 @@ if (isSomeChar!Char1 && isSomeChar!Char2)
import std.conv : to;
import std.traits : EnumMembers;

debug(string) trustedPrintf("string.lastIndexOf.unittest\n");

foreach (S; AliasSeq!(string, wstring, dstring))
{
foreach (T; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1636,8 +1616,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.indexOfAny.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1677,8 +1655,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.traits : EnumMembers;

debug(string) trustedPrintf("string.indexOfAny(startIdx).unittest\n");

foreach (S; AliasSeq!(string, wstring, dstring))
{
foreach (T; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1804,8 +1780,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.lastIndexOfAny.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1859,8 +1833,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.lastIndexOfAny(index).unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -1986,8 +1958,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.indexOf.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -2032,8 +2002,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.indexOfNeither(index).unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -2144,8 +2112,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.lastIndexOfNeither.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -2191,8 +2157,6 @@ if (isSomeChar!Char && isSomeChar!Char2)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.lastIndexOfNeither(index).unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(string, wstring, dstring))
Expand Down Expand Up @@ -2511,8 +2475,6 @@ if (!isSomeString!S && is(StringTypeOf!S))
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.splitLines.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(char[], wchar[], dchar[], string, wstring, dstring))
Expand Down Expand Up @@ -2762,8 +2724,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.lineSplitter.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(char[], wchar[], dchar[], string, wstring, dstring))
Expand Down Expand Up @@ -3148,8 +3108,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.strip.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!( char[], const char[], string,
Expand Down Expand Up @@ -3353,7 +3311,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.chomp.unittest\n");
string s;

assertCTFEable!(
Expand Down Expand Up @@ -3645,8 +3602,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.chop.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(char[], wchar[], dchar[], string, wstring, dstring))
Expand Down Expand Up @@ -4032,8 +3987,6 @@ unittest
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.justify.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(char[], wchar[], dchar[], string, wstring, dstring))
Expand Down Expand Up @@ -4372,8 +4325,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.detab.unittest\n");

assertCTFEable!(
{
foreach (S; AliasSeq!(char[], wchar[], dchar[], string, wstring, dstring))
Expand Down Expand Up @@ -4711,8 +4662,6 @@ unittest
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.entab.unittest\n");

assertCTFEable!(
{
assert(entab(cast(string) null) is null);
Expand Down Expand Up @@ -5294,8 +5243,6 @@ deprecated
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.inPattern.unittest\n");

assertCTFEable!(
{
assert(inPattern('x', "x") == 1);
Expand Down Expand Up @@ -5370,8 +5317,6 @@ deprecated
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.count.unittest\n");

assertCTFEable!(
{
assert(countchars("abc", "a-c") == 3);
Expand Down Expand Up @@ -5425,8 +5370,6 @@ deprecated
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.removechars.unittest\n");

assertCTFEable!(
{
assert(removechars("abc", "a-c").length == 0);
Expand Down Expand Up @@ -5503,8 +5446,6 @@ deprecated
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.squeeze.unittest\n");

assertCTFEable!(
{
string s;
Expand Down Expand Up @@ -5645,8 +5586,6 @@ if (isSomeString!S)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.succ.unittest\n");

assertCTFEable!(
{
assert(succ(string.init) is null);
Expand Down Expand Up @@ -5819,8 +5758,6 @@ C1[] tr(C1, C2, C3, C4 = immutable char)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("std.string.tr.unittest\n");

// Complete list of test types; too slow to test'em all
// alias TestTypes = AliasSeq!(
// char[], const( char)[], immutable( char)[],
Expand Down Expand Up @@ -6143,8 +6080,6 @@ if (isSomeString!S ||
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("isNumeric(in string, bool = false).unittest\n");

assertCTFEable!(
{
// Test the isNumeric(in string) function
Expand Down Expand Up @@ -6458,8 +6393,6 @@ string[string] abbrev(string[] values) @safe pure
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.abbrev.unittest\n");

assertCTFEable!(
{
string[] values;
Expand Down Expand Up @@ -6601,8 +6534,6 @@ if (isConvertibleToString!Range)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.column.unittest\n");

assertCTFEable!(
{
assert(column(string.init) == 0);
Expand Down Expand Up @@ -6716,8 +6647,6 @@ if (isSomeString!S)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.wrap.unittest\n");

assertCTFEable!(
{
assert(wrap(string.init) == "\n");
Expand Down Expand Up @@ -6858,8 +6787,6 @@ if (isSomeString!S)
import std.conv : to;
import std.exception : assertCTFEable;

debug(string) trustedPrintf("string.outdent.unittest\n");

template outdent_testStr(S)
{
enum S outdent_testStr =
Expand Down