Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jul 7, 2017

The random coverage error appearing in #5570, is, as usual, our fault.

https://codecov.io/gh/dlang/phobos/compare/551ffa6e0d247dcdb560feb2e297346886de17d0...8cf459324303a19307ec173d36596dff99d71a11/changes

image

However, this one can be fixed easily - we just need to use the fixed seeds for the random number generator ;-)

@wilzbach wilzbach added Infrastructure:automation Review:Trivial typos, formatting, comments labels Jul 7, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

CyberShadow commented Jul 7, 2017

Obvious bugfix aside, did you check that the e == 25 line is covered by one of the fixed seeds? If it's not, then the random coverage changes will likely not be fixed.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 7, 2017

did you check that the e == 25 line is covered by one of the fixed seeds? If it's not, then the random coverage changes will likely not be fixed.

Yep, that's how I noticed the bug ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants