Skip to content

Retry parameter storage class tuple#5633

Closed
wilzbach wants to merge 4 commits intodlang:masterfrom
rainers:retry_ParameterStorageClassTuple
Closed

Retry parameter storage class tuple#5633
wilzbach wants to merge 4 commits intodlang:masterfrom
rainers:retry_ParameterStorageClassTuple

Conversation

@wilzbach
Copy link
Contributor

#5626 restarted due to the CI problem

Previous description:

reboot #5427 by @WalterBright as it is required for the new mangling in dlang/dmd#6998

Maybe something else changes, but locally I cannot reproduce an error with toDelegate!(void function(FreeListRef!(shared(int), true), int delegate(int, int) pure nothrow @nogc @safe, int, int) nothrow @nogc @system) as in the previous attempts build logs.

@wilzbach
Copy link
Contributor Author

Urgh that didn't help:

image

@wilzbach wilzbach closed this Jul 19, 2017
@CyberShadow
Copy link
Member

Did you see what were the mismatching commits?

@wilzbach
Copy link
Contributor Author

Did you see what were the mismatching commits?

Sorry, didn't note them down.

@CyberShadow
Copy link
Member

Previous working theory was that this only occurred after a force push (where it showed the pre- and post-force-push commits), but if it happened even if the branch wasn't updated since it was created, that's curious.

@CyberShadow
Copy link
Member

Oh, I'm guessing that might be related to that this PR has the exact same commits as another PR. Might be worth trying to rebase before opening a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants