Closed
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
andralex
approved these changes
Jul 20, 2017
std/functional.d
Outdated
| $(TD Forwards function arguments while saving ref-ness. | ||
| )) | ||
| $(TR $(TD $(LREF lessThan)), $(LREF greaterThan)), $(D $(LREF equalTo) | ||
| $(TR $(TD $(LREF lessThan), $(LREF greaterThan), $(D $(LREF equalTo)) |
Contributor
Author
There was a problem hiding this comment.
Yes, that's why it's based against stable & I realized that std.typecons is need of a bookmark table ;-)
wilzbach
force-pushed
the
typecons-bookmarktable
branch
from
5e68525 to
a056ec6
Compare
MetaLang
approved these changes
Jul 20, 2017
Member
MetaLang
left a comment
MetaLang
left a comment
There was a problem hiding this comment.
LGTM. Just gonna wait for the doc build.
Member
|
What's this SHA mismatch message? |
Contributor
Author
|
MetaLang
suggested changes
Jul 20, 2017
std/functional.d
Outdated
| $(TD Forwards function arguments while saving ref-ness. | ||
| )) | ||
| $(TR $(TD $(LREF lessThan)), $(LREF greaterThan)), $(D $(LREF equalTo) | ||
| $(TR $(TD $(LREF lessThan), $(LREF greaterThan), $(LREF equalTo)) |
Member
There was a problem hiding this comment.
Shouldn't this be a separate PR?
wilzbach
force-pushed
the
typecons-bookmarktable
branch
from
a056ec6 to
f9f8b7d
Compare
This was referenced Jul 21, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a weird-looking bookmark table in std.functional and then had a look at other bookmark tables and found that std.typecons was in deep need:
Before:
After:
Other interesting modules