Don't use alias this in chunks implementation.

[quickfur]

Due to an oversight in PR #5624, an unnecessary alias this was left in the implementation of Chunks. This causes an import visibility error when Chunks is instantiated from another module. There is actually no need for this at all, since empty can just refer to impl directly.

I need some help with the unittest, though: the bug doesn't show up in a unittest in this module, obviously, because it only happens when Chunks is instantiated in another module. How to write a Phobos unittest in this case?? As in, where to put it?

[dlang-bot]

Thanks for your pull request, @quickfur!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[JackStouffer]

unittest.d still exists for some reason; could use that

[quickfur]

Unfortunately, that doesn't seem to be compiled by the makefile at all. :-(

[quickfur]

LOL, apparently it's only built by the win64 and win32 makefiles.

Argh... hate this gratuitous makefile copy-pasta...

[wilzbach]

Unfortunately, that doesn't seem to be compiled by the makefile at all. :-(

A file in std.internal then?

[quickfur]

@wilzbach Probably a good idea. Which one, though?

[wilzbach]

@wilzbach Probably a good idea. Which one, though?

A new one? DMD should be smart enough to avoid adding additional symbols when the entire module is empty and even if not, we can always use make to ignore / add it only to the test target.

[quickfur]

Done, let's hope I didn't screw up the makefile too badly. :-D

[PetarKirov]

I think you need to update win32.mak and win64.mak, if I am not mistaken it should be the SRC_STD_INTERNAL rule.

One blunt way to ensure that the your changes to build system are ok is to make the test fail unconditionally and verify that it fails on all Autotester runners in about the same way.

[PetarKirov]

Apart from the build system stuff, LGTM.

[quickfur]

Fixed windows makefiles.

[CyberShadow]

LGTM

[andralex]

thx!