Skip to content

stdio: remove reliance on std*** being aliasable #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
Sep 4, 2017
Merged

stdio: remove reliance on std*** being aliasable #5718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions std/stdio.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4518,7 +4518,7 @@ Initialize with a message and an error code.
}

// Undocumented but public because the std* handles are aliasing it.
@property ref File makeGlobal(alias handle)()
@property ref File makeGlobal(int _iob)()
{
__gshared File.Impl impl;
__gshared File result;
Expand All @@ -4537,7 +4537,9 @@ Initialize with a message and an error code.
break;
if (atomicOp!"+="(spinlock, 1) == 1)
{
impl.handle = handle;
impl.handle = _iob == 0 ? core.stdc.stdio.stdin :
_iob == 1 ? core.stdc.stdio.stdout :
core.stdc.stdio.stderr;
result._p = &impl;
atomicOp!"+="(spinlock, uint.max / 2);
break;
Expand All @@ -4554,7 +4556,7 @@ Initialize with a message and an error code.
it is thread un-safe to reassign `stdin` to a different `File` instance
than the default.
*/
alias stdin = makeGlobal!(core.stdc.stdio.stdin);
alias stdin = makeGlobal!(0);

///
@safe unittest
Expand Down Expand Up @@ -4582,7 +4584,7 @@ alias stdin = makeGlobal!(core.stdc.stdio.stdin);
it is thread un-safe to reassign `stdout` to a different `File` instance
than the default.
*/
alias stdout = makeGlobal!(core.stdc.stdio.stdout);
alias stdout = makeGlobal!(1);

/**
The standard error stream.
Expand All @@ -4591,7 +4593,7 @@ alias stdout = makeGlobal!(core.stdc.stdio.stdout);
it is thread un-safe to reassign `stderr` to a different `File` instance
than the default.
*/
alias stderr = makeGlobal!(core.stdc.stdio.stderr);
alias stderr = makeGlobal!(2);

@system unittest
{
Expand Down