Skip to content

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Sep 9, 2017

Fixes build failure when building testsuite on ARM.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor

wilzbach commented Sep 9, 2017

If we can't fix the underlying problem, maybe we could at least split the unittest so that some of the @safe part can still be alive?

@ibuclaw
Copy link
Member Author

ibuclaw commented Sep 9, 2017

@wilzbach - all asserts use strtod(), or do something unsafe (taking the address of local variable), so I don't consider splitting really necessary.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just skimmed over the long unittest module on my phone earlier.

@wilzbach wilzbach merged commit 526af0f into dlang:stable Sep 10, 2017
@ibuclaw ibuclaw deleted the armconv branch September 13, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants