Upgrade D-Scanner: Compile D-Scanner with -fPIC#5750
Merged
dlang-bot merged 1 commit intodlang:masterfrom Oct 1, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl:dr: yet another step to make the dev build work smoother with
-fPIC- we are close to the finish line :)By default, DMD passes
-fPICto the linker, but sadly the development build of DMD uses a different config and thus doesn't pass-fPICby default. The PR to change this doesn't seem to move into any direction: dlang/dmd#7002However, thanks to dlang/druntime#1880 and #5586, which are both in
masternow, the development build oflibphobos2.ais compiled with-fPIC🎉 and we can thus compile D-Scanner with-fPICas well.Regarding PRs at D-Scanner: