Skip to content

Upgrade D-Scanner: Compile D-Scanner with -fPIC#5750

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:compile-dscanner-with-fpic
Oct 1, 2017
Merged

Upgrade D-Scanner: Compile D-Scanner with -fPIC#5750
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:compile-dscanner-with-fpic

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Oct 1, 2017

tl:dr: yet another step to make the dev build work smoother with -fPIC - we are close to the finish line :)

By default, DMD passes -fPIC to the linker, but sadly the development build of DMD uses a different config and thus doesn't pass -fPIC by default. The PR to change this doesn't seem to move into any direction: dlang/dmd#7002
However, thanks to dlang/druntime#1880 and #5586, which are both in master now, the development build of libphobos2.a is compiled with -fPIC 🎉 and we can thus compile D-Scanner with -fPIC as well.

Regarding PRs at D-Scanner:

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlang-bot dlang-bot merged commit e6865b8 into dlang:master Oct 1, 2017
@wilzbach wilzbach deleted the compile-dscanner-with-fpic branch December 11, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants