Skip to content

Conversation

@wilzbach
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach force-pushed the markdownify-algorithm branch from 1a3f914 to fc0c29f Compare December 29, 2017 00:24
@wilzbach
Copy link
Contributor Author

We can also do this file by file if that's easier.

Copy link
Contributor

@JackStouffer JackStouffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve this. Because this was done via program and not by hand you can infer the correct-ness by looking at a few examples of the output (and it would take too long to manually review all of it).

@wilzbach
Copy link
Contributor Author

Because this was done via program and not by hand you can infer the correct-ness by looking at a few examples of the output (

Not that there are still some cases in which DDoc auto-highlights a token, compare e.g.

Old: http://dtest.dlang.io/artifact/website-d4a3e415e1933b1bf95375258832afc0fa2d38d9-cf0b6d829835d57b259c20e7d81ed874/web/library-prerelease/std/algorithm/sorting/top_n.html
New: http://dtest.dlang.io/artifact/website-d4a3e415e1933b1bf95375258832afc0fa2d38d9-dd7fe723dce5f3ab6d81d0f7a8671d92/web/library-prerelease/std/algorithm/sorting/top_n.html

and look at "r.length" after "satisfy".

Though AFAICT these changes look benign as the auto-highlighting actually does make sense in these spots.

@JackStouffer
Copy link
Contributor

Let's get on with this.

@dlang-bot dlang-bot merged commit db2d241 into dlang:master Jan 3, 2018
@d-random-contributor
Copy link

First change: backticks don't nest.

@wilzbach wilzbach deleted the markdownify-algorithm branch March 30, 2018 16:11
This was referenced Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants