-
-
Notifications
You must be signed in to change notification settings - Fork 747
file.d: add overflow checks #5990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @JackStouffer! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that this only works because readImpl is completely @trusted and getcwd isn't @safe yet.
See #5928
std/file.d
Outdated
| the buffer, in characters, including the null-terminating character. | ||
| */ | ||
| wchar[4096] buffW = void; //enough for most common case | ||
| version (unittest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StdUnittest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #5932
3f24d97 to
9d8a331
Compare
|
@wilzbach done |
wilzbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Is it sane to depend on a std.experimental module in the main production branch of the library? |
|
We already discussed this in #4712 where the consensus between everyone (including @WalterBright and @andralex) was that using the |
Taken over from #4712