Changed all instances of FormatSpec in toString to const ref #5995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackStouffer
requested review from
DmitryOlshansky,
MetaLang,
PetarKirov,
andralex and
kyllingstad
as code owners
Contributor
|
Thanks for your pull request, @JackStouffer! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JackStouffer
changed the title
Contributor
Author
|
This is technically a breaking change mind you. However, it's very rare that a user would call these methods directly and not just use |
JackStouffer
force-pushed
the
toString-ref
branch
from
21614b6 to
dc291a1
Compare
Member
|
The size of FormatSpec is 72 bytes making the argument difficult. Might be better to just compress it to 64 bytes... I'll accept this anyway. |
andralex
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5991 (comment)
While in this instance, the code compiled just fine, the problem is that a
const refparameter informatObjectended up being copied in said function ifFormatSpecwasn't marked asref. This poses a problem becauseFormatSpecis quite a large struct, not to mention the fact that we've already gone through the trouble of making a pointer to one, so making a copy is just extra work.