Partially Fix Issue 10828 - Add output range version of toString functions to std.datetime.Date #6060
Conversation
|
Thanks for your pull request, @JackStouffer! Bugzilla references
|
JackStouffer
force-pushed
the
date-tostring
branch
from
57b5e63 to
5b7d214
Compare
std/datetime/date.d
Outdated
| +/ | ||
| string toISOExtString() const @safe pure nothrow | ||
| /// ditto | ||
| void toISOString(W)(ref W writer) const if (isOutputRange!(W, char)) |
There was a problem hiding this comment.
Nit: constraints should be indented on the same level as the function declaration.
std/datetime/date.d
Outdated
| } | ||
|
|
||
| /// ditto | ||
| void toSimpleString(W)(ref W writer) const if (isOutputRange!(W, char)) |
There was a problem hiding this comment.
Nit: constraints should be indented on the same level as the function declaration.
std/datetime/date.d
Outdated
| } | ||
|
|
||
| /// ditto | ||
| void toString(W)(ref W writer) const if (isOutputRange!(W, char)) |
There was a problem hiding this comment.
Nit: constraints should be indented on the same level as the function declaration.
std/datetime/date.d
Outdated
| import core.time;// : TimeException; | ||
| import std.traits : isSomeString, Unqual; | ||
| import std.typecons : Flag; | ||
| import std.range.primitives;// : isOutputRange; |
There was a problem hiding this comment.
Please use selective imports for new imports - otherwise you risk leaking the entire module.
There was a problem hiding this comment.
I thought it was the opposite?
There was a problem hiding this comment.
We can't convert the existing imports to selective imports because that would close the symbol leakage: #5584
JackStouffer
force-pushed
the
date-tostring
branch
from
5b7d214 to
1eeadc8
Compare
|
These random vibed errors are getting pretty annoying |
|
Yeah, I am opening a new Jenkins issue almost every second day - https://github.com/dlang/ci/issues (not mentioning hitting the existing ones), but I don't have a concrete proposal except for dropping Jenkins, creating one common bash script and running that one all repos on a reliable CI (e.g. CircleCi or SemaphoreCI). As we already have the build scripts for Jenkins it probably wouldn't take that long to do... |
3 participants
Using the
toStringformat from #5991, updateDate's string methods to accept output ranges.