Fix Issue 18299: std.datetime.date.cmpTimeUnits does not throw a Date… #6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @JackStouffer! Bugzilla references
|
jmdavis
approved these changes
Jan 25, 2018
quickfur
reviewed
Jan 25, 2018
| immutable indexOfLHS = countUntil(tstrings, lhs); | ||
| immutable indexOfRHS = countUntil(tstrings, rhs); | ||
| immutable indexOfLHS = countUntil(timeStrings, lhs); | ||
| immutable indexOfRHS = countUntil(timeStrings, rhs); |
Member
There was a problem hiding this comment.
Just curious, what was the reason for this change?
Contributor
Author
There was a problem hiding this comment.
No reason to make a second copy of the reference when countUntil takes it by value
quickfur
approved these changes
Jan 25, 2018
Contributor
|
Once #6070 is merged, CircleCi can be restarted here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TimeException