Skip to content

Conversation

@carblue
Copy link
Contributor

@carblue carblue commented Jan 26, 2018

… (const scope, but dmd treats it as const); see also merged dlang.org PR #2126 or issue #17928

This is a trivial, 'basic' PR in a coming series of PRs dedicated to make std.uni compilable with -dip1000.

Until yesterday's merge of dlang/dlang.org#2126, there was the confusing situatiom, that parameter storage class 'in' was documented in spec as being an equivalent of 'const scope', though dmd treats 'in' as an equivalent of 'const' currently.
Likely, the code author wanted to/should express 'const scope' by using 'in', thus this PR is just a blunt copy-and-paste to sort out the bulk of (-dip1000) compiler errors.
Anyway, I'll check for scope required or not in another pass.

… (const scope, but dmd treats it as const); see also merged dlang.org PR #2126 or issue #17928
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @carblue! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17928 [scope] in is not treated as const scope

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlang-bot dlang-bot merged commit c1757f4 into dlang:master Feb 12, 2018
@carblue carblue deleted the std_uni_fix_in branch February 13, 2018 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants