Replaced version(unittest) blocks with version(StdUnittest) #6107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackStouffer
requested review from
CyberShadow,
DmitryOlshansky,
MartinNowak,
MetaLang,
PetarKirov,
andralex,
burner,
dnadlinger,
ibuclaw,
jmdavis,
kyllingstad,
schveiguy and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @JackStouffer! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
approved these changes
Feb 2, 2018
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Thanks! Looks good! One small request: Could you use this opportunity to unify the style of the version blocks? version(StdUnittest) is our official style guide. It's a simple sed, but I can always run this on your behalf on this PR.
JackStouffer
force-pushed
the
stdunittest
branch
from
dcb4a07 to
18cbb29
Compare
Contributor
Author
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should result in faster compiles for unittest builds in some cases.