Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Feb 9, 2018

This is required for dlang/dmd#7834
The uses of _ has been wrong in both cases.

CC @quickfur

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@quickfur
Copy link
Member

quickfur commented Feb 9, 2018

Whoa, what's with the ddoc test failure?

@wilzbach wilzbach force-pushed the remove-undefined-ddoc branch from 68adbcf to a24b450 Compare February 9, 2018 18:20
@quickfur
Copy link
Member

quickfur commented Feb 9, 2018

I don't think you want to use π here; it will break LaTeX generation, won't it?

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 9, 2018

Whoa, what's with the ddoc test failure?

Argh damn. We still use the old Ddoc behavior here. I expanded the PI macro - an alternative would have been to rename it.

@quickfur
Copy link
Member

quickfur commented Feb 9, 2018

But what about the other lines that reference $(PI)? How come they compile, but this line doesn't?

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 9, 2018

it will break LaTeX generation, won't it?

We only generate LaTeX from the spec, not the documentation.
I just did inserted, what Ddoc would have done manually:

* PI = π

But as mentioned I can also rename the macro if you prefer this.

@quickfur
Copy link
Member

quickfur commented Feb 9, 2018

Ohhh I know why... because of the stupid auto-highlight, since PI is being defined, it needs to be escaped otherwise it will mangle the macro. :-(

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 9, 2018

But what about the other lines that reference $(PI)? How come they compile, but this line doesn't?

Auto-escaping - the thing you want to change in your PR ;-)

@quickfur
Copy link
Member

quickfur commented Feb 9, 2018

Haha, yeah. This is why we need to kill that misfeature with fire. :-( I guess we should just go with π for now.

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 9, 2018

Yes I think so too.
Once you PR is in, we can easily go back to PI (though honestly it doesn't matter).

@dlang-bot dlang-bot merged commit a6fe1dd into dlang:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants