std.regex: Alignment hotfix #6185
Conversation
This fixes the unittests for LDC on ARM (with enabled optimizations). The code used to store a class instance (whose size isn't padded) right before some buffer, without any padding inbetween. The buffer is thus susceptible to misalignment; e.g., `BacktrackingMatcher.dupTo()` casts the buffer from `void[]` to `size_t[]` (in `initExternalMemory()`), simply assuming an alignment >= `size_t.alignof`, which only holds if the prepended class instance size is a multiple of that (as `malloc()` returns a sufficiently aligned block already in this case).
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
The recent |
LGTM. Indeed it ddin't occur to me that class instance size != align instance size. I think for structs it accounts for that. |
|
@kinke I think there could be more uses of classInstanceSize, might be worth it to double check. |
This fixes the unittests for LDC on ARM (with enabled optimizations).
The code used to store a class instance (whose size isn't padded) right before some buffer, without any padding inbetween. The buffer is thus susceptible to misalignment; e.g.,
BacktrackingMatcher.dupTo()casts the buffer fromvoid[]tosize_t[](ininitExternalMemory()), simply assuming an alignment >=size_t.alignof, which only holds if the prepended class instance size is a multiple of that (asmalloc()returns a sufficiently aligned block already in this case).