Skip to content

Conversation

@carblue
Copy link
Contributor

@carblue carblue commented Feb 18, 2018

@wilzbach
Discussion about this topic is also in
#6041
#6181

aa represents the current state of "phobos -dip1000 compilability".

I preferred associative array aa entries in the "modulename-notation" (e.g. aa[std.array]) instead of OS-dependant "pathname-notation" (didn't recall whether windows can cope with forward-slashes).
But this only defers the issue to the call-site (I use Linux, i.e. /): $(aa[$(subst /,.,$(basename $<))])

Used currently in 2 rules, e.g.
%.test : %.d $(LIB)
T=mktemp -d /tmp/.dmd-run-test.XXXXXX &&
(
$(DMD) -od$$T $(DFLAGS) $(aa[$(subst /,.,$(basename $&lt;))]) -main $(UDFLAGS) $(LIB) -defaultlib= -debuglib= $(LINKDL) -cov -run $< ;
RET=$$? ; rm -rf $$T ; exit $$RET
)

Positioning $(aa[$(subst /,.,$(basename $&lt;))]) after $(DFLAGS) resulting in e.g. -dip25 -dip1000 always worked for me, the compiler picked up the last one.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @carblue! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor

Looks good and I'm aware that #6041 is blocking this.
(Though of course I hope that we can switch to -dip1000 by default soon)

CC @CyberShadow @MartinNowak - are you okay with this approach too?

@carblue
Copy link
Contributor Author

carblue commented Mar 7, 2018

This lacks reply from CyberShadow or MartinNowak for more than 2 weeks, thus closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants