Skip to content

Conversation

@wilzbach
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, isn't this one of those places where we'd want to do preemptive UTF-8 validation before putting bytes in a string? I think we decided that if we want to at least make autodecoding nothrow, then we need to enforce that string types contain only valid UTF-8, as anything else is an error.

@wilzbach
Copy link
Contributor Author

I think we decided that if we want to at least make autodecoding nothrow, then we need to enforce that string types contain only valid UTF-8, as anything else is an error.

I thought that effort didn't go anywhere?
https://wiki.dlang.org/DIP76

Actually, isn't this one of those places where we'd want to do preemptive UTF-8 validation before putting bytes in a string?

Hmm, do we do this somewhere else?

@CyberShadow
Copy link
Member

Hmm, do we do this somewhere else?

Well, readText is the canonical example.

@CyberShadow
Copy link
Member

I thought that effort didn't go anywhere?

Yeah, I don't think we decided we didn't want to do this, either... it seems to keep coming up from time to time, along with the general autodecoding discussions.

@dlang-bot dlang-bot merged commit c7c83e6 into dlang:master Mar 14, 2018
@wilzbach wilzbach deleted the remove-cast branch March 14, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants