Fix spurious build failures in std.file by using more unique test directories#6347
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 26, 2018
Merged
Fix spurious build failures in std.file by using more unique test directories#6347dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
| import std.ascii : letters; | ||
| import std.conv : to; | ||
| import std.path : buildPath; | ||
| auto myFile = tempDir.buildPath("my_tmp_file"); |
Contributor
There was a problem hiding this comment.
Why not auto myFile = deleteme ~ "my_tmp_file";?
Seems like this is more complicated than it needs to be.
Contributor
Author
There was a problem hiding this comment.
Because this is the public example for tempDir - wouldn't make sense to not use it.
Contributor
There was a problem hiding this comment.
auto myFile = tempDir.buildPath(deleteme);?
Contributor
Author
There was a problem hiding this comment.
deleteme = "/tmp/<randomid>.<pid>
JackStouffer
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we added a whole bunch of new test to std.file, auto-tester sometimes fails:
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3092231&isPull=true
So it's probably a good idea to use unique directories like
deletemeorin the case of the
tempDirexamples, generating a unique file.