More removal of version(unittest)

[schveiguy]

See #6450

[dlang-bot]

Thanks for your pull request, @schveiguy!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6453"

[schveiguy]

Putting a trusted function like this in the global namespace is not a good idea.

[schveiguy]

Note, uint32_t and uint16_t are nowhere else in this file. I have no idea what these were for so I removed them. If they are critical to have, they should go somewhere else.

[schveiguy]

writefln is used in commented out lines below. I put in this comment because before it was imported by the version(unittest) block.

[schveiguy]

ping @wilzbach what is this circleci error in typecons? I can't figure out if it's something I did or not, but I didn't touch typecons.

[JackStouffer]

Random error, ignore it for the time being.

[schveiguy]

Random error

Ugh. Now doc builder too.

[schveiguy]

Doc failure seems repeatable, but I don't know what it means. @wilzbach or @CyberShadow ?

[CyberShadow]

Er, I'm not sure @wilzbach worked on the spec testing stuff, maybe he knows?

Might be exposing a latent compiler bug through some edge case.

[wilzbach]

Looks really weird:

---
void main() {
import std.stdio;
        struct S { int x; float y; }

        int foo(S s) { return s.x; }

        foo( S(1, 2) ); // set field x to 1, field y to 2
        
}
---
/usr/bin/ld: error in __stdin.o(.eh_frame); no .eh_frame_hdr table will be created.
/usr/bin/ld: __stdin.o: invalid string offset 1096055152 >= 528 for section `.strtab'
/usr/bin/ld: unknown operator '(' in complex symbol
/usr/bin/ld: final link failed: Invalid operation
collect2: error: ld returned 1 exit status
Error: linker exited with status 1

I can try more testing tomorrow, but for now I have no idea why this is failing.

[schveiguy]

@wilzbach thanks for looking into it.

[wilzbach]

Regarding the DAutoTest failure -> dlang/dlang.org#2345