Remove deprecated std.string funcs inPattern, squeeze, countChars, removeChars and munch

[ghost]

No description provided.

[dlang-bot]

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6507"

[ghost]

The author of the project tester item that uses them is notified.

[wilzbach]

IIRC pegged is no longer in development, so I am not sure whether this notification will help :/

[ghost]

IIRC pegged is no longer in development, so I am not sure whether this notification will help :/

No it's okay. It's still maintained and the fix is actually in the trunk since a few hours. The author just has to push a git tag and this PR will be green.

[jmdavis]

Sorry, but these should not be removed yet. When it says in the documentation that they're to be removed in May 2018, that means that they're to be removed from the documentation in May 2018. The public documentation needs to be removed and @@@DEPRECATED-2018-05@@@ should be changed to

// Explicitly undocumented. It will be removed in May 2019. @@@DEPRECATED_2019-05@@@

e.g. https://github.com/dlang/phobos/blob/master/std/datetime/timezone.d#L165

The symbols themselves should not be removed yet.

[ghost]

Sorry

No problem i didn't know it works like that. Just one think: the problem is that it leads to undocumented public symbols which our linter doesn't like much.

[jmdavis]

No problem i didn't know it works like that.

It's how it's been working, though there's been enough confusion over it that I'm probably going to need to change how that's handled so that the documentation indicates when the symbol is going to be completely removed, and then there can be a non-public comment indicating when the documentation is supposed to be removed. But I haven't switched over to that yet, and this was deprecated using the approach that we've been using for several years now. So, what's listed in the documentation is the date for removal from the docs, not the final removal date.

the problem is that it leads to undocumented public symbols which our linter doesn't like much.

Are you talking about something in the circleci stuff? Well, it's going to need to be able to handle undocumented, deprecated symbols, because that's a standard part of the deprecation process. Symbols are deprecated and documented for one year, then deprecated and undocumented for a year, and then finally removed. So, they're going to sit there with no public documentation for about a year as a normal part of the process.