Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 4, 2018

A start at removing the no longer needed underscore escaping from Phobos.
This was done partially by a script to get an initial set of replacements:

import std.experimental.all;
void main(string[] args)
{
    foreach (file; dirEntries(".", "*.d", SpanMode.depth))
    {
        auto text = file.readText;
        auto packageName = file.baseName.stripExtension;
        auto moduleName = file.dirName.baseName;
        foreach (rep; [packageName, moduleName])
            text = text.replace("_"~rep, rep);
        text.toFile(file);
    }
}

And then manually adding the replacements to the git index.
I might have missed a few instances (or skipped the ones which were a bit more complicated),
but we can easily find them later with the DDOC_AUTO_PSYMBOL_SUPPRESS macro).

See also:

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6542"

Copy link
Contributor

@JackStouffer JackStouffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough

@schveiguy
Copy link
Member

I was starting to look through all these, but there's too many! Luckily we have the doc preview, I can see only a few html files changed, and all the changes are fixes (removing unintentional underscores).

@dlang-bot dlang-bot merged commit a56ae80 into dlang:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants