Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 6, 2018

Okay I forgot that I created #5928 a while ago and it seems we now have three options to fix https://issues.dlang.org/show_bug.cgi?id=18024

  1. Fix Issue 18024 - checkedint.Warn should be @safe #5928 - remove Warn from Abort
  2. Fix Issue 18024 - checkedint.Warn should be @safe (alternative) #6369 - use @trusted Warn
  3. this PR - add Assert and alias Abort(T) = Checked!(Checked!(T, Abort), Warn)

All options have their pros/cons, but mostly they don't differ so much, so we should really start to agree on one option..

See also: #6369 and #5928

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6550"

@RazvanN7
Copy link
Collaborator

This has been fixed by: #7909

@RazvanN7 RazvanN7 closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants