copy() should not leak its source #6560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
the
Review:Vision
WalterBright
requested review from
JackStouffer,
PetarKirov,
andralex and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#6560" |
WalterBright
force-pushed
the
copy-scope
branch
2 times, most recently
from
108e815 to
a3715f2
Compare
Member
Author
|
Blocked by dlang/dmd#8346 |
dukc
approved these changes
Aug 22, 2018
Contributor
|
|
thewilsonator
approved these changes
Nov 15, 2018
thewilsonator
force-pushed
the
copy-scope
branch
from
8f46ecb to
fabc892
Compare
Contributor
|
Rebased, |
RazvanN7
force-pushed
the
copy-scope
branch
from
9e0d8a8 to
7d93468
Compare
RazvanN7
force-pushed
the
copy-scope
branch
from
7d93468 to
708ad4a
Compare
LightBender
added
the
Review:Salvage
Contributor
|
@WalterBright is this still good to go? DIP1000 is such a fraught topic these days. |
Contributor
|
Since it's a template, scope should be inferred here, not annotated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.