Skip to content

[trivial] Getter property should not return void#6593

Merged
wilzbach merged 1 commit intodlang:masterfrom
ntrel:void-getter
Jun 18, 2018
Merged

[trivial] Getter property should not return void#6593
wilzbach merged 1 commit intodlang:masterfrom
ntrel:void-getter

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 18, 2018

Needed for dlang/dmd#8320.

@ntrel ntrel requested a review from andralex as a code owner June 18, 2018 12:25
@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label Jun 18, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6593"

@wilzbach wilzbach merged commit 25078aa into dlang:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments